Conversation
…nditionals
Ansible 2.19 tightened conditional evaluation and now rejects expressions
like `default({'changed': false})` inside a `when:` with "Conditional
expressions must be strings." Replace the dict-literal default with an
attribute-level default, which is semantically equivalent and parses under
both 2.18 and 2.19.
Closes #139
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughUpdated conditional expressions in Elasticsearch handlers to resolve Ansible 2.19 strict conditionals compatibility. Replaced dict-literal defaults with attribute-level defaults across four handlers, changing from Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~5 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #139.
Ansible 2.19 tightened conditional evaluation so expressions like
default({'changed': false})inside awhen:clause now fail withConditional expressions must be strings.. The restart handlers in #137 all used that pattern to guard against the freshstart facts being undefined. Swapped to an attribute-level default (.changed | default(false) | bool), which is semantically equivalent — both forms returnfalse(don't block the restart) when the fact is undefined or when.changedis missing — and parses cleanly under both 2.18 and 2.19.The
elasticsearch_defaultscenario'sside_effect.ymlalready exercises the Restart Elasticsearch handler end-to-end on a 2-node cluster, so the code path is covered. Note that CI still pinsansible-core<2.19because of the unrelatedrole_pathscoping change blocking that upgrade, so 2.19-strict mode is not yet directly exercised by CI — the fix is equivalent on 2.18.Scope is intentionally narrow to what #139 calls out. Other
default({})usages (inuntil:clauses across tasks) use empty-dict literals, not key-value dicts, and haven't been reported as failing; leaving those alone until we can actually run 2.19 in CI.Summary by CodeRabbit